multiple SSPs/BEs support for SOF--Kernel Part by keyonjie · Pull Request #4 · thesofproject/linux

keyonjie · 2018-06-25T07:51:45Z

We need SOFT part merged together, that is stream_name rename for nocodec topology to make nocodec topology works.

plbossart

I don't really understand what this patchset fixes compared to the previous version, this is still somewhat messy in terms of link declaration, setup and handling of multiple outputs.

plbossart · 2018-06-25T16:13:50Z

it original from Liam, And it is the maximum of cpu_dai caps, it can still be reduced by the FE/PCM caps:
hw->channels_min = max(chan_min, cpu_stream->channels_min);
hw->channels_max = min(chan_max, cpu_stream->channels_max);

so I think leaving them as 16 has no harm.

8 chan is correct, my original value is wrong.

OK, let me change them to 8 in v3.

plbossart · 2018-06-25T16:15:12Z

Can you look at Rakesh's patches, I think we could update this with Analog, Alt-Analog and Digital?

OK, I will go and get that for HDMI enabling, I believe we may need to refine them during enabling each BEs, as I talked previously, it's not one shot fix, it is only framework implementation here.

keyon, can you check the HDA/HDMI naming should be consistent per platform (but it may change between different platforms).

confirmed they are same with cAVS ones defined in skl-pcm.c

I meant use something this instead, see alsa-devel [PATCH v3 11/13] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers

+static struct snd_soc_dai_driver hdac_hda_dais[] = {
+{

.id = HDAC_ANALOG_DAI_ID,

.name = "Analog Codec DAI",

.ops = &hdac_hda_dai_ops,

.playback = {

.stream_name = "Analog Codec Playback",

.channels_min = 1,

.channels_max = 16,

.rates = SNDRV_PCM_RATE_8000_192000,

.formats = STUB_FORMATS,

.sig_bits = 24,

},

.capture = {

.stream_name = "Analog Codec Capture",

.channels_min = 1,

.channels_max = 16,

.rates = SNDRV_PCM_RATE_8000_192000,

.formats = STUB_FORMATS,

.sig_bits = 24,

},
+},
+{

.id = HDAC_DIGITAL_DAI_ID,

.name = "Digital Codec DAI",

.ops = &hdac_hda_dai_ops,

.playback = {

.stream_name = "Digital Codec Playback",

.channels_min = 1,

.channels_max = 16,

.rates = SNDRV_PCM_RATE_8000_192000,

.formats = STUB_FORMATS,

.sig_bits = 24,

},

.capture = {

.stream_name = "Digital Codec Capture",

.channels_min = 1,

.channels_max = 16,

.rates = SNDRV_PCM_RATE_8000_192000,

.formats = STUB_FORMATS,

.sig_bits = 24,

},
+},
+{

.id = HDAC_ALT_ANALOG_DAI_ID,

.name = "Alt Analog Codec DAI",

.ops = &hdac_hda_dai_ops,

.playback = {

.stream_name = "Alt Analog Codec Playback",

.channels_min = 1,

.channels_max = 16,

.rates = SNDRV_PCM_RATE_8000_192000,

.formats = STUB_FORMATS,

.sig_bits = 24,

},

.capture = {

.stream_name = "Alt Analog Codec Capture",

.channels_min = 1,

.channels_max = 16,

.rates = SNDRV_PCM_RATE_8000_192000,

.formats = STUB_FORMATS,

.sig_bits = 24,

},
+}

so we need 3 for HDA legacy codecs? And should this be same for all platforms?

plbossart · 2018-06-25T16:16:30Z

I still don't get how we handle multiple nocodec outputs with this solution?

multiple nocodec cpu_dais are created during probing, each dai driver defined in platform driver(e.g. apl.c) will be used and corresponding nocodec dai_link will be created in sof_nocodec_setup().

plbossart · 2018-06-25T16:18:02Z

Is there a way to use common tables when APL/CNL/ICL are identical?

it is possible, but separating them is more flexible at the moment in my opinion, if they are totally same after all our features are implemented and they do have no difference, we can merge them then.

SSP rates on all the platforms are the same atm, so safe to merge.

Hi Liam, sorry can't get your point here, so do all of us aligned on using common tables for APL/CNL/ICL?

how about putting it in hda-pcm.c?

plbossart · 2018-06-25T16:19:00Z

Pretty sure SKL/KBL don't have 6 SSPs

let's shrink them then.

by the way, do you know how much we have for that? I get information from cAVS 1.5 HAS that I2SPC is 3, but the document claims it support all BXT/GLK/SPT platforms.

per my understanding, for SKL+, cAVS driver use the common table defined in skl-pcm.c, that is the same table we defined in apl.c/cnl.c/skl.c, so here for SKL/KBL, let's keep it, which is same with cAVS one?

plbossart · 2018-06-25T16:24:30Z

I don't understand why we set formats that are not valid except for SSP, and how we deal with DMIC or HDAudio with this work.
Specifically with DMIC we know it's capture only so shouldn't we look at the information in ops->drv[i] to avoid changing things that make limited sense?

here it is for nocodec only, but maybe you are right, if somebody defines to use nocodec DMIC in tplg file, then...

again, this BE.dai_fmt for nocodec actually don't take any effect, maybe I should remove this assignment here to make you feel more relax. :)

plbossart · 2018-06-25T16:25:12Z

is this still needed to have a nocodec-dai?

good point, let me fix it, thanks.

keyonjie · 2018-06-26T08:25:31Z

update to v2 with addressing some comments.

lgirdwood · 2018-06-26T14:58:51Z

This file can be completely removed now and this function should be in sof/utils.c
I would also change this function to sof_platform_add_all_bes()

how about the probe()/remove(), the platform driver, and the card sound card register invoking?

They are fine, they should register the card and get around any deferred probe binding.

lgirdwood · 2018-06-26T15:00:30Z

We are no longer "sof-nocodec" as this code can be used for platforms that support add-in audio cards/devices. We should probably pass this in.

Liam's comment was not addressed?

I had a call with Liam about this, and aligned to keep this no-codec driver and keep it simple. The reason for it is that we can't leverage deffer probe without using platform probing.

lgirdwood · 2018-06-26T15:01:35Z

rename nocodec_ -> sof_platform_

same, Liam's comment isn't addressed.

lgirdwood · 2018-06-26T15:02:12Z

What happens if this fails ? Need to handle errors

let me add handle of this.

lgirdwood · 2018-06-26T15:02:57Z

I'll merge this into my upstream patch.

Register all DAI from platform driver Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>

lgirdwood

Just minor things to fix for me.

lgirdwood · 2018-06-28T11:58:52Z

It's probably worth commenting here that some products who use this DAI array only physically have a subset of the DAIs, but no harm is done here by adding the whole set.

lgirdwood · 2018-06-28T12:00:12Z

CHT has 6 SSPs, best to add them and include a comment.

are you sure CHT has 6 SSPs? I see from your previous patch series that it is set and commented as 3/

and 3 is same with sst-mfld-platform-pcm.c also.

/* BE CPU Dais */
{
.name = "ssp0-port",
.ops = &sst_be_dai_ops,
.playback = {
.stream_name = "ssp0 Tx",
.channels_min = SST_STEREO,
.channels_max = SST_STEREO,
.rates = SNDRV_PCM_RATE_48000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
.capture = {
.stream_name = "ssp0 Rx",
.channels_min = SST_STEREO,
.channels_max = SST_STEREO,
.rates = SNDRV_PCM_RATE_48000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
},
{
.name = "ssp1-port",
.ops = &sst_be_dai_ops,
.playback = {
.stream_name = "ssp1 Tx",
.channels_min = SST_STEREO,
.channels_max = SST_STEREO,
.rates = SNDRV_PCM_RATE_8000|SNDRV_PCM_RATE_16000|SNDRV_PCM_RATE_48000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
.capture = {
.stream_name = "ssp1 Rx",
.channels_min = SST_STEREO,
.channels_max = SST_STEREO,
.rates = SNDRV_PCM_RATE_8000|SNDRV_PCM_RATE_16000|SNDRV_PCM_RATE_48000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
},
{
.name = "ssp2-port",
.ops = &sst_be_dai_ops,
.playback = {
.stream_name = "ssp2 Tx",
.channels_min = SST_STEREO,
.channels_max = SST_STEREO,
.rates = SNDRV_PCM_RATE_48000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
.capture = {
.stream_name = "ssp2 Rx",
.channels_min = SST_STEREO,
.channels_max = SST_STEREO,
.rates = SNDRV_PCM_RATE_48000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
},
};

lgirdwood · 2018-06-28T12:01:25Z

They are fine, they should register the card and get around any deferred probe binding.

xiulipan · 2018-06-29T06:12:56Z

You may need to refine the the code here to make dai link can be found for the codec machine drivers.

linux/sound/soc/soc-core.c

Line 1001 in cb05347

struct snd_soc_dai_link *snd_soc_find_dai_link(struct snd_soc_card *card,

This will cause some machine driver dai could not found. It may fix
thesofproject/soft#9

keyonjie · 2018-06-29T10:50:59Z

xiuli, the issue you mentioned should be fixed in tplg file, we should set .id value for DAI in test codec tplg.

keyonjie · 2018-06-29T10:55:48Z

Liam/Pierre, just updated, please help review.

plbossart

Almost looks good, just a couple of minors comments to look into. Thanks Keyon.

plbossart · 2018-06-29T15:26:44Z

why is this needed? Can we add later when it's actually doing something?

are you meaning this hda-dai.c file? this is suggested by Liam to add, and it addressing your comment about common dai driver table for SKL/APL/CNL also.

plbossart · 2018-06-29T15:29:28Z

I believe the max number of channels should be 16 for HDAudio (same for all digital parts below)

please feel free to change it, as I am not able to test them yet, so I can't give any comment about it.

plbossart · 2018-06-29T15:30:46Z

do we support FLOAT on BDW? (same comments for all machines btw, I don't think we can deal with FLOAT on a DAI.

This is also initiated by Liam, Liam, do you have comment on it?

plbossart · 2018-06-29T15:32:26Z

Liam's comment was not addressed?

plbossart · 2018-06-29T15:33:05Z

same, Liam's comment isn't addressed.

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

This patch create nocodec BE DAI links based on platform dai drivers, with it, we can support multiple SSP/BEs for nocodec mode. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

1. Don't override cpu_dai_name, we will reuse those defined in machine driver. 2. We should keep dpcm_playback and dpcm_capture defined for BEs, not both of them are supported by BEs sometimes. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

…dynamic We should use .dynamic for all FE dai_links, so change probe and trace buffer ones here to align to that. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

keyonjie · 2018-07-02T15:52:34Z

Hi Pierre/Liam, new version updated, I think it address all comments from you, please help review.

plbossart

There is one isolated 16->8 ch issue that needs to be fixed in a follow-up patch. let's merge this.

plbossart · 2018-07-02T16:00:53Z

+	.name = "SSP2 Pin",
+	.playback = SOF_DAI_STREAM("ssp2 Tx", 1, 8,
+				   SNDRV_PCM_RATE_8000_192000, SKL_FORMATS),
+	.capture = SOF_DAI_STREAM("ssp2 Rx", 1, 16,


oops, let me send incremental fix soon.

plbossart requested changes Jun 25, 2018

View reviewed changes

ranj063 mentioned this pull request Jun 25, 2018

SSP related changes #7

Merged

keyonjie force-pushed the sof-pr branch from 8b4fe1e to 1f959f7 Compare June 26, 2018 08:20

lgirdwood requested changes Jun 26, 2018

View reviewed changes

keyonjie force-pushed the sof-pr branch from 1f959f7 to 73e2982 Compare June 27, 2018 05:14

keyonjie and others added 3 commits June 28, 2018 18:31

ASoC: SOF: core: register DAIs from platform drivers.

4ad1d02

Register all DAI from platform driver Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: pcm: remove DAI driver

ab41adb

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: nocodec: give DAI driver more meaningful name

7faad3b

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>

keyonjie force-pushed the sof-pr branch from 73e2982 to f4bc955 Compare June 28, 2018 10:33

lgirdwood requested changes Jun 28, 2018

View reviewed changes

keyonjie force-pushed the sof-pr branch from f4bc955 to 23749be Compare June 29, 2018 10:51

plbossart reviewed Jun 29, 2018

View reviewed changes

keyonjie force-pushed the sof-pr branch from 23749be to 6955c4d Compare July 2, 2018 05:23

xiulipan mentioned this pull request Jul 2, 2018

machine driver update for UP2 #12

Merged

keyonjie force-pushed the sof-pr branch from 6955c4d to c877618 Compare July 2, 2018 10:31

lrgirdwo and others added 7 commits July 2, 2018 22:20

ASoC: SOF: intel: SKL, CNL, APL platform DAIs

73121fd

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: Intel BDW platform DAIs

e9b822a

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: Intel BYT platform DAIs

d124438

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: Intel HSW platform DAIs

3856d52

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: SOF: nocodec: create BE DAI links based on platform dai drivers

25f8bbd

This patch create nocodec BE DAI links based on platform dai drivers, with it, we can support multiple SSP/BEs for nocodec mode. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

ASoC: Intel: bxt-tdf8532: change probe and trace buffer dai_links to …

d660d58

…dynamic We should use .dynamic for all FE dai_links, so change probe and trace buffer ones here to align to that. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>

keyonjie force-pushed the sof-pr branch from c877618 to d660d58 Compare July 2, 2018 15:49

plbossart approved these changes Jul 2, 2018

View reviewed changes

plbossart merged commit 5be0d42 into thesofproject:topic/sof-dev Jul 2, 2018

mengdonglin mentioned this pull request May 17, 2019

[BUG][CML]Paplay has no sound after plug out DP #954

Closed

tokyovigilante mentioned this pull request Nov 7, 2019

Lenovo patches #1442

Merged

paulstelian97 mentioned this pull request Oct 12, 2021

Dell Latitude 9520: No Audio #3206

Closed

lucastanure mentioned this pull request May 2, 2022

Missing SSP2 (I2S) from Up Xtreme WHL-I5 #3624

Closed

wisbit mentioned this pull request Sep 2, 2022

No sound at all - TECLAST F15 PLUS - Intel Corporation Celeron/Pentium Silver Processor High Definition Audio #3842

Closed

aplitvinov mentioned this pull request Apr 21, 2023

No sound on Huawei Matebook 14 (2021) - even on Linux 6.2 #4305

Open

davieslc mentioned this pull request Apr 15, 2026

No audio on ASUS Zenbook S14 UX5406AA (Panther Lake): sof_sdw fails to create DAI links for cs35l56 #5721

Closed

Uh oh!

Conversation

keyonjie commented Jun 25, 2018

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keyonjie commented Jun 26, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment